Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ioutil and upgrade deps #411

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Cleanup ioutil and upgrade deps #411

merged 3 commits into from
Oct 20, 2022

Conversation

mfridman
Copy link
Collaborator

This PR replaces io/ioutil (lint warnings) with their equivalents os or io.

https://go.dev/doc/go1.16#ioutil

Also upgrades deps.

@mfridman
Copy link
Collaborator Author

Why why why every time I update ClickHouse, on a minor, something breaks.

v2.2.0 -> v2.3.0

Error: ../../../go/pkg/mod/github.com/!click!house/ch-go@v0.47.3/proto/ipv4.go:5:2: package net/netip is not in GOROOT (/opt/hostedtoolcache/go/1.17.13/x64/src/net/netip)
Error: Process completed with exit code 1.

net/netip was added in go1.18

@mfridman
Copy link
Collaborator Author

Going to leave ClickHouse on v2.2.0 for now..

@mfridman mfridman merged commit 1c15215 into master Oct 20, 2022
@mfridman mfridman deleted the cleanup-ioutil branch October 20, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant