remove tls
override from mysql dsn normalizing
#468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
This PR removes the overriding of the
tls
parameter in the MySQL DSN. If I understand the code correctly,goose
want's to use thecustom
TLS mode, if a cert file is provided. In the other cases, it should just let the DSN dictate what TLS mode to use. Please let me know what you think about this. For me, at least, this allows me to settls
totrue
again.