Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AddMigrationNoTxContext invalid filename #572

Merged
merged 3 commits into from
Jul 22, 2023
Merged

fix: AddMigrationNoTxContext invalid filename #572

merged 3 commits into from
Jul 22, 2023

Conversation

mfridman
Copy link
Collaborator

@mfridman mfridman commented Jul 22, 2023 •
edited

Fix #571

  • Fix number of runtime.Caller in AddMigrationNoTxContext
  • Mark following functions as deprecated:
    • AddMigration
    • AddNamedMigration
    • AddMigrationNoTx
    • AddNamedMigrationNoTx
  • Add tests for Go migration register functions

@mfridman mfridman changed the title [WIP] - fix AddMigrationNoTxContext fix: AddMigrationNoTxContext invalid filename Jul 22, 2023
@mfridman mfridman marked this pull request as ready for review July 22, 2023 16:15
@mfridman mfridman merged commit 5c84746 into master Jul 22, 2023
8 checks passed
@mfridman mfridman deleted the gh-571 branch July 22, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddMigrationContext vs. AddMigrationNoTxContext
1 participant
@mfridman