Add goose provider with unimplemented methods #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
commented
Sep 14, 2023
provider.go
Outdated
| // If opts is nil, the default options are used. See ProviderOptions for more information. | ||
| // | ||
| // Unless otherwise specified, all methods on Provider are safe for concurrent use. | ||
| func NewProvider(dialect Dialect, db *sql.DB, opts *ProviderOptions) (*Provider, error) { |
There was a problem hiding this comment.
@VojtechVitek wdyt about adding the Provider to the /v3 module instead of cutting an entire new major version /v4.
This was the plan for #507, but after a lot of thought, I think we can iterate on the Provider and extend it to support a bunch of features folks have been asking for.
There was a problem hiding this comment.
sounds like a good idea :)
mfridman
force-pushed
the
gh-379-provider
branch
from
7be1a0c
to
62e1b6a
Compare
mfridman
force-pushed
the
gh-379-provider
branch
from
2a82cbe
to
32114dc
Compare
mfridman
force-pushed
the
gh-379-provider
branch
from
ac8c81d
to
0355c61
Compare
mfridman
commented
Sep 16, 2023
| // meant to be exhaustive or test every possible database dialect. It is meant to verify the Store | ||
| // interface works against a real database. | ||
|
|
||
| func TestStore(t *testing.T) { |
There was a problem hiding this comment.
This allows us to test the Store implementation in isolation from migrations.
┌───────────────────────────────────────────────────────────────────────────────────────────────────┐
│ STATUS │ ELAPSED │ PACKAGE │ COVER │ PASS │ FAIL │ SKIP │
│─────────┼─────────┼─────────────────────────────────────────────────┼───────┼──────┼──────┼───────│
│ PASS │ 1.94s │ github.com/pressly/goose/v3/internal/sqladapter │ 70.8% │ 3 │ 0 │ 0 │
└───────────────────────────────────────────────────────────────────────────────────────────────────┘
There's both a short (sqlite3 with a temp test directory) and long (postgres container) test
mfridman
commented
Oct 7, 2023
| // Functional options are used to configure the Provider. See [ProviderOption] for more information. | ||
| // | ||
| // Unless otherwise specified, all methods on Provider are safe for concurrent use. | ||
| func NewProvider(dialect Dialect, db *sql.DB, fsys fs.FS, opts ...ProviderOption) (*Provider, error) { |
There was a problem hiding this comment.
I'm fairly happy with the ergonomics of this API.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stubs out a
Providerin the current /v3 module. It takes the ideas and best parts from #507 and attempts to bring them into the current module in a backwards-compatible way.I may have been wrong, and cutting a /v4 was probably not the best approach. We can leave the /v4 as a future iteration based on feedback and one last (famous last words) cleanup of the package.
There will be notable differences between the
Providermethods and the existing*Migrationmethods / direct functions, for example: