Timeout Flag #627
Timeout Flag #627
Conversation
| @@ -99,6 +100,56 @@ func TestMigrateUpTo(t *testing.T) { | |||
| check.Number(t, gotVersion, upToVersion) // incorrect database version | |||
| } | |||
|
|
|||
| func TestMigrateUpTimeout(t *testing.T) { | |||
There was a problem hiding this comment.
I think these tests are simulating the library timeout, but we should probably have something that exercises the --timeout flag and uses pg_sleep (sqlite would be ideal, but I don't think there's a way to do that in sqlite)
There was a problem hiding this comment.
README.md
Outdated
| @@ -105,6 +105,8 @@ Options: | |||
| file path to SSL key in pem format (only supported on mysql) | |||
| -table string | |||
| migrations table name (default "goose_db_version") | |||
| -timeout duration | |||
| duration that the queries should run for; e.g. 1h13m | |||
There was a problem hiding this comment.
| duration that the queries should run for; e.g. 1h13m | |
| maximum duration queries allowed to run; e.g. 1h13m |
Not sure if that's better?
There was a problem hiding this comment.
Went with:
-timeout duration
maximum allowed duration for queries to run; e.g., 1h13m
You mean something like this, right? Where timeout was set to 5s, but migration 2 had a
Same as the previous one, but in this case goose partially migrated before the timeout was reached? |
Note, this isn't really needed since the context outlives the main function. But go is being difficult despite adding nolint comment //nolint:govet // The context outlives the main function
All good! Glad I got a chance to contribute! |
Adds a CLI flag
-timeoutso that users can specify a duration for how long the migrations should be able to run.Closes #576
Some edge cases
NO TRANSACTIONthe timeout wont be respected if it's been exceeded for that part of the migration.Let me know if I should change anything else.