do not close prepare #12
Conversation
felipeweb
requested review from
avelino,
lerrua,
crgimenes,
marioidival,
gtsalles and
cassiobotaro
| if err := sc.Err(); err != nil { | ||
| t.Errorf("expected no errors, but got %v", err) | ||
| } | ||
| sc = Insert("INSERT INTO test(name) VALUES('testcache')") |
There was a problem hiding this comment.
This is right? Try save twice same data ?
There was a problem hiding this comment.
it is just to test cache
| if err := sc.Err(); err != nil { | ||
| t.Errorf("expected no errors, but got %v", err) | ||
| } | ||
| sc = Delete("DELETE FROM test WHERE name='test cache'") |
There was a problem hiding this comment.
Return some error here... Try delete same data twice
There was a problem hiding this comment.
it is just to test cache
|
I have decided to remove the transaction from all the functions because we only execute one operation, there is no need to be under a transaction. |
|
@felipeweb First question about it is: I aren't SQL specialist but this no make sense to me. |
|
@marioidival it is just to test if cache doesn't bug on insert query i can't imagine this scenario, but in the database is completely possible if table not have unique key |
prest/prest#205