-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the url generator available on the events #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm late (long weekend :))
I think this is a very good start, thank you.
Do you planned to update/add tests in the same PR ?
Yes, that was my plan. |
Ok, addressed the comments. Let me know if you'd like me to change the deprecation/exception messages. For the tests, I was thinking the following:
Let me know if you'd like anything else. |
I know that this bundle has some bad practices in tests, but I'm trying to fix this.
👍, 100% agree with this |
Ok, I believe this is ready for a final review. I believe the phpstan errors are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work !
Fixes #286. Tests pass still so hopefully that means this is BC. Before I finalize, I'd like to ensure this direction is acceptable.
TODO: