Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid implementing deprecated interface #309

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Avoid implementing deprecated interface #309

merged 1 commit into from
Oct 9, 2023

Conversation

norkunas
Copy link
Contributor

@norkunas norkunas commented May 4, 2023

No description provided.

@norkunas
Copy link
Contributor Author

norkunas commented May 4, 2023

✔️

@norkunas
Copy link
Contributor Author

norkunas commented Oct 9, 2023

ping @yann-eugone

@yann-eugone
Copy link
Member

Sorry for being late, I did not had much time to work on OS last year

I'm not sure if this require a major version
I understand that the message handling will still work
But I believe that if someone has developed a toolkit around message handlers having that interface, the toolkit won't work anymore
We can say it's very niche, but still, to me it is BC

@yann-eugone yann-eugone self-assigned this Oct 9, 2023
@yann-eugone yann-eugone self-requested a review October 9, 2023 07:35
@yann-eugone yann-eugone merged commit 649767e into prestaconcept:3.x Oct 9, 2023
8 checks passed
yann-eugone pushed a commit that referenced this pull request Oct 9, 2023
Revert "Avoid implementing deprecated interface (#309)"
bda679e 
This reverts commit 649767e.
@yann-eugone yann-eugone mentioned this pull request Oct 9, 2023
Merged
yann-eugone pushed a commit that referenced this pull request Oct 9, 2023
Revert "Avoid implementing deprecated interface (#309)" (#311)
d347549 
This reverts commit 649767e.

Co-authored-by: Yann Eugoné <yeugone@prestaconcept.net>
@norkunas
Copy link
Contributor Author

norkunas commented Oct 9, 2023

Thanks for merging

@norkunas norkunas deleted the dep branch October 9, 2023 08:35
evertharmeling pushed a commit to evertharmeling/PrestaSitemapBundle that referenced this pull request Dec 13, 2023
@evertharmeling
Revert "Avoid implementing deprecated interface (prestaconcept#309)" (p…
6a32509 
…restaconcept#311)

This reverts commit 649767e.

Co-authored-by: Yann Eugoné <yeugone@prestaconcept.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-eugone yann-eugone yann-eugone approved these changes

Assignees

@yann-eugone yann-eugone

Labels
bc break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@norkunas @yann-eugone