Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somes search of hook name show another one #1654

Closed
PrestaEdit opened this issue May 6, 2023 · 5 comments
Closed

Somes search of hook name show another one #1654

PrestaEdit opened this issue May 6, 2023 · 5 comments
Assignees

Comments

@PrestaEdit
Copy link
Contributor

Capture d’écran 2023-05-06 à 15 46 01

@thomasnares
Copy link
Contributor

Hi @PrestaEdit , this is inherent of the way our hook regex matching works to maybe make false positives.

We can update the matched hook to actionAdmin<ControllerName><Action>Before to fix the false positive.

But, which hook should have been returned for your example actionProductSearchProviderRunQueryBefore ?

@thomasnares
Copy link
Contributor

Need to Document :

actionProductSearchProviderRunQueryBefore (classes/controllet/ProductListingFrontController.php)
actionProductSearchProviderRunQueryAfter (classes/controllet/ProductListingFrontController.php)

@thomasnares
Copy link
Contributor

But only in V8, not in 1.7

@kpodemski
Copy link
Contributor

As the hooks page has been improved drastically on the v8 page, we won't be backporting changes to 1.7 anymore.

If you notice something to improve in v8 version let us now @PrestaEdit 💪🏻 or maybe submit a PR 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants