Adapt to the changes in dplyr 0.6.0 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes: - Implement `db_desc` dispatching on `PrestoConnection`. - Some of the functions in dplyr moved to `dbplyr`. So we add a `dbplyr` compatibility function which pseudo-imports the function from the 'correct' package. This way we can provide backwards compatibility. - Update the tests to use 'quosures' and the new evaluation framework where necessary. resolves #75.
While this works with most types, it does not with `raw`.
Either the current form, or:
r <- as.raw(0)
rq <- quo(r)
...
as(a, !!rq)
...
works.
|
@onurfiliz updated the pull request - view changes |
cosinequanon
approved these changes
Apr 27, 2017
| l <- list(a=1L) | ||
| expect_equal( | ||
| translate_sql( | ||
| as(x, !!l), |
There was a problem hiding this comment.
I'm confused about this line, why are we applying !! to a list?
| ) | ||
| expect_equal( | ||
| translate_sql( | ||
| as(x, !!local(list(a=Sys.time()))), |
|
Honestly I'm not sure why but these have to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes:
db_descdispatching onPrestoConnection.dbplyr. So we add adbplyrcompatibility function which pseudo-imports the function from the
'correct' package. This way we can provide backwards compatibility.
where necessary.
resolves #75.