Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Change StandardTypes to be a enum class #16246

Open
rongrong opened this issue Jun 10, 2021 · 2 comments
Open

Refactor: Change StandardTypes to be a enum class #16246

rongrong opened this issue Jun 10, 2021 · 2 comments
Labels
available-to-pickup beginner-task

Comments

@rongrong
Copy link
Contributor

Currently StandardTypes is a class hosting a bunch of string constant. This means we are using types as regular strings all over the place and cannot enforce certain parameters to be a type, unless converting to the java class Type. It would be beneficial to replace this with a enum class. StandardTypes enum should have the type name (current values defined in the class) and whether they are parametric type or not.
@abhikarkamkar
Copy link

hi @rongrong I am ready to work on this, If possible assign it to me

abhikarkamkar added a commit to abhikarkamkar/presto that referenced this issue Jun 13, 2021
@abhikarkamkar
Fix for [prestodb#16246](prestodb#16246)
e65eeb0 
Changed StandardTypes to be a enum class
To fetch enum value have added getter method
@abhikarkamkar abhikarkamkar mentioned this issue Jun 13, 2021
Closed
@abhikarkamkar
Copy link

@rongrong hi can you review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
available-to-pickup beginner-task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rongrong @abhikarkamkar