Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change StandardTypes to be a enum class #16246 #16257

Closed
wants to merge 1 commit into from

Conversation

abhikarkamkar
Copy link

Fix for #16246

Changed StandardTypes to be an enum class
To fetch enum value have added getter method

Changed StandardTypes to be a enum class
To fetch enum value have added getter method
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

@xumingming
Copy link
Contributor

I think all the sites referencing StandardTypes should use the fields directly, rather than field.getEnumValue() because field.getEnumValue() is still type of string

@abhikarkamkar
Copy link
Author

@xumingming hi can you please elaborate more ? I want to get value assigned to enum. For eg for given enum BIGINT("bigint")
to get value "bigint". I cannot use valueOf since it would give me BIGINT as value, I need "bigint" for that either I need to override toString() method or use an getter method. I have chosen getter approach

@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

@stale stale bot added the stale label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants