Minor bug fix in BlackHoleConnector #12457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highker
approved these changes
Mar 11, 2019
presto-blackhole/src/test/java/com/facebook/presto/plugin/blackhole/TestBlackHoleSmoke.java
Outdated
Show resolved
Hide resolved
wenleix
force-pushed
the
fixblack
branch
3 times, most recently
from
55bf3b1
to
7ec9926
Compare
BlackholeConnector cannot have tables with same table names in different schemas. This is because originally BlackHoleConnector only supports `default` schema so it use the table name string to identify table. When creating schema was supported in 4e522f3, the table identity should be updated to use SchemaTableName.
kokosing
pushed a commit
to kokosing/trino
that referenced
this pull request
May 1, 2019
BlackholeConnector cannot have tables with same table names in different schemas. This is because originally BlackHoleConnector only supports `default` schema so it use the table name string to identify table. When creating schema was supported in 4e522f355ed7f0711d877e2259e489a8ebf626b9, the table identity should be updated to use SchemaTableName. Extracted from: prestodb/presto#12457
kokosing
pushed a commit
to trinodb/trino
that referenced
this pull request
May 1, 2019
BlackholeConnector cannot have tables with same table names in different schemas. This is because originally BlackHoleConnector only supports `default` schema so it use the table name string to identify table. When creating schema was supported in 4e522f355ed7f0711d877e2259e489a8ebf626b9, the table identity should be updated to use SchemaTableName. Extracted from: prestodb/presto#12457
FernandoWerneck
pushed a commit
to SlicingDice/presto
that referenced
this pull request
May 13, 2019
BlackholeConnector cannot have tables with same table names in different schemas. This is because originally BlackHoleConnector only supports `default` schema so it use the table name string to identify table. When creating schema was supported in 4e522f355ed7f0711d877e2259e489a8ebf626b9, the table identity should be updated to use SchemaTableName. Extracted from: prestodb/presto#12457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlackholeConnector cannot have tables with same table names in different
schemas.
This is because originally BlackHoleConnector only supports
defaultschema so it use the table name string to identify table. When creating
schema was supported in 4e522f3 (related PR is #9702), the
table identity should be updated to use SchemaTableName.