Support explain verification #15101
Merged
Support explain verification #15101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caithagoras
changed the title
caithagoras
force-pushed
the
s1
branch
12 times, most recently
from
06c39a0
to
1811342
Compare
caithagoras
changed the title
caithagoras
force-pushed
the
s1
branch
7 times, most recently
from
9879ca9
to
10ad3bf
Compare
caithagoras
requested review from
sujay-jain
and removed request for
bhhari,
tdcmeehan and
yingsu00
caithagoras
force-pushed
the
s1
branch
2 times, most recently
from
8d87536
to
340ecf9
Compare
sujay-jain
reviewed
Sep 9, 2020
...to-verifier/src/main/java/com/facebook/presto/verifier/framework/DataVerificationConfig.java
Outdated
Show resolved
Hide resolved
|
Still reviewing - first 2 commits LGTM |
caithagoras
force-pushed
the
s1
branch
5 times, most recently
from
3e07ba0
to
5dd8d16
Compare
sujay-jain
reviewed
Sep 10, 2020
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
Show resolved
Hide resolved
sujay-jain
reviewed
Sep 10, 2020
...to-verifier/src/main/java/com/facebook/presto/verifier/event/DeterminismAnalysisDetails.java
Outdated
Show resolved
Hide resolved
|
@mbasmanova This PR is ready now. Thank you for helping! |
Convert MatchResult to an interface and move the data-verification- specific implementation of the MatchResult to DataMatchResult.
QueryBundle contained a field tableName, but not all query rewrites result in queries with a target table. Move the field to a subclass DataQueryBundle.
Add a new functionality to the verifier to allow explain verification. For each query pairs to be verified, explain both control and test, and compare the query plans. Verification is marked as succeeded as long as the test query can be explained. Introduced a new field matchType in the output event, which can be used to indicate whether there is plan difference. For non-DML queries, we don't care much about plan difference and hence the control query and plan comparison are skipped.
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new functionality to the verifier to allow explain verification.
For each query pairs to be verified, explain both control and test, and
compare the query plans. Verification is marked as succeeded as long as
the test query can be explained.
Introduced a new field matchType in the output event, which can be used
to indicate whether there is plan difference.
For non-DML queries, we don't care much about plan difference and hence
the control query and the plan comparison are skipped.