Add option to do more precise ACL checks

[prithvip]

Before this change, Presto would check for column access permission on
all columns referenced in any part of the query.
This behavior can sometimes be undesirable, for example, in this query:

SELECT name FROM (SELECT * FROM nation)

During execution of this query, access checks would be performed on all
columns in the table nation, even though only the column name would
actually be read during the execution of the query, and the other
columns in the table have no impact on the query results.

This change introduces a new sesion property,
check_access_control_on_utilized_columns_only, which, when
enabled, will only perform access control checks on columns that would
actually be required to produce the query output, ignoring columns that
are referenced in the query, but are not required to compute the query
results.

Test plan -

1. Unit tests to cover a good range of query shapes.
2. Test on production workload queries

== RELEASE NOTES ==

General Changes
* Add session property ``check_access_control_on_utilized_columns_only``, which, when enabled, only performs access control checks on columns that would actually be required to produce the query output, ignoring columns that are referenced in the query, but are not required to compute the query results.

[kaikalur]

First set of comments.

[kaikalur]

Will be good to have more expression coverage - look at the g4 file and add all non-standard places that can have expressions - patterns like lambdas, using, grouping sets, order by of aggs etc.

[kaikalur]

Also update the title to say make the ACL checks more precise to include any and all that impact the final output.

[rongrong]

Test failures seem to be related?

[prithvip]

Will be good to have more expression coverage - look at the g4 file and add all non-standard places that can have expressions - patterns like lambdas, using, grouping sets, order by of aggs etc.

Done, added a bunch of tests to cover expressions

Also update the title to say make the ACL checks more precise to include any and all that impact the final output.

Done

[kaikalur]

Thanks for the extensive set of tests! A few more widely used cases missing that you should add those.

[kaikalur]

Also add window functions - both in aggs as well as partition by and order by without referring to them in the select list.

[prithvip]

Also add window functions - both in aggs as well as partition by and order by without referring to them in the select list.

I have a testWindowFunction which covers column references in a PARTITION BY and ORDER BY clause in a window function

[kaikalur]

Also add window functions - both in aggs as well as partition by and order by without referring to them in the select list.

Also add window functions - both in aggs as well as partition by and order by without referring to them in the select list.

I have a testWindowFunction which covers column references in a PARTITION BY and ORDER BY clause in a window function

+1

[kaikalur]

Just add one more test for struct/row types - I know we do only top level structs but good to have coverage. Similarly that are potentially short circuited like:

IF(FALSE, x, y) -> ACL both x and y
WHERE x > 0 AND false AND y < 10 -> ACL both x,y

[prithvip]

Just add one more test for struct/row types - I know we do only top level structs but good to have coverage. Similarly that are potentially short circuited like:

IF(FALSE, x, y) -> ACL both x and y
WHERE x > 0 AND false AND y < 10 -> ACL both x,y

I have test for ROW in testConstructors, and I added tests covering these short-circuit cases.