Add REST based Function Namespace Manager #23328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abevk2023
changed the title
abevk2023
changed the title
abevk2023
force-pushed
the
rest_function_namespace_manager
branch
from
154130d
to
6237fc4
Compare
|
Can you document this endpoint using OpenAPI? #22982 |
tdcmeehan
reviewed
Aug 7, 2024
| @Override | ||
| public Collection<SqlInvokedFunction> listFunctions(Optional<String> likePattern, Optional<String> escape) | ||
| { | ||
| return latestFunctions.values(); |
There was a problem hiding this comment.
I think the above two methods are OK to not implement for now, but this needs to be implemented.
There was a problem hiding this comment.
Avoided caching the list of functions.
abevk2023
force-pushed
the
rest_function_namespace_manager
branch
4 times, most recently
from
2143320
to
4395f82
Compare
abevk2023
force-pushed
the
rest_function_namespace_manager
branch
from
4395f82
to
e70e3e7
Compare
abevk2023
force-pushed
the
rest_function_namespace_manager
branch
4 times, most recently
from
3fa0650
to
bcbd009
Compare
abevk2023
changed the title
…es from the REST server.
abevk2023
force-pushed
the
rest_function_namespace_manager
branch
from
bcbd009
to
27a609e
Compare
tdcmeehan
reviewed
Sep 4, 2024
| */ | ||
| package com.facebook.presto.functionNamespace; | ||
|
|
||
| public interface FunctionsApi |
There was a problem hiding this comment.
Can you explain why we need this interface? Can't we just use a concrete class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RestBasedFunctionNamespaceManager which can retrieve the remote functions from a REST server