-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST based Function Namespace Manager #23328
base: master
Are you sure you want to change the base?
Add REST based Function Namespace Manager #23328
Conversation
154130d
to
6237fc4
Compare
Can you document this endpoint using OpenAPI? #22982 |
@Override | ||
public Collection<SqlInvokedFunction> listFunctions(Optional<String> likePattern, Optional<String> escape) | ||
{ | ||
return latestFunctions.values(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the above two methods are OK to not implement for now, but this needs to be implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoided caching the list of functions.
2143320
to
4395f82
Compare
4395f82
to
e70e3e7
Compare
3fa0650
to
bcbd009
Compare
…es from the REST server.
bcbd009
to
27a609e
Compare
*/ | ||
package com.facebook.presto.functionNamespace; | ||
|
||
public interface FunctionsApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we need this interface? Can't we just use a concrete class?
Adds RestBasedFunctionNamespaceManager which can retrieve the remote functions from a REST server