improve ux with hints for serve all requests for the /static/ and /media/ paths
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rixx
approved these changes
Mar 26, 2024
| ; never run debug in production | ||
| ; never run debug in production. Make sure you serve all requests for the | ||
| ; `/static/` and `/media/` paths when debug is False. | ||
| ; See [installation](https://docs.pretalx.org/administrator/installation/#step-7-ssl) for more information |
There was a problem hiding this comment.
Not sure it's particularly useful to have a markdown-formatted link in a file that will never be parsed as markdown, and will make the link harder to select and open in most file editors
There was a problem hiding this comment.
Yes, you're absolutely right about the markdown... Should i remove it?
| @@ -8,6 +8,7 @@ services: | |||
| - redis | |||
| - db | |||
| environment: | |||
| # Hint: Make sure you serve all requests for the `/static/` and `/media/` paths when debug is False. See [installation](https://docs.pretalx.org/administrator/installation/#step-7-ssl) for more information | |||
There was a problem hiding this comment.
I'm not convinced that adding this informaitn here is valuable – you might as well add information on every other environment variable and/or setting and/or component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #56