Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent superusers #259

Closed
rixx opened this issue Nov 12, 2017 · 0 comments
Closed

Prevent superusers #259

rixx opened this issue Nov 12, 2017 · 0 comments
Labels
size: small Easy and/or quick to do stage: up for grabs type: bug Needs fix

Comments

@rixx
Copy link
Member

rixx commented Nov 12, 2017

Superusers are granted more rights than they should be – they see buttons to accept a submission when it's already been accepted, for instance, since permission checks kinda short out. We should either fix this, or – and this may be more desirable anyways – introduce an admin role that is permitted to create new events, and stop relying on is_superuser completely, since being a superuser has weird connotations, and an admin or is_staff is clearer. We should also show a large warning when a superuser is using the site.

@rixx rixx added type: bug Needs fix size: small Easy and/or quick to do stage: up for grabs labels Nov 12, 2017
@rixx rixx added this to the 2017-12 milestone Dec 5, 2017
@rixx rixx removed this from the 2017-12 milestone Jan 7, 2018
@rixx rixx changed the title Fix superuser rights Prevent superusers Jan 21, 2018
rixx added a commit that referenced this issue Jan 22, 2018
@rixx rixx closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small Easy and/or quick to do stage: up for grabs type: bug Needs fix
Projects
None yet
Development

No branches or pull requests

1 participant