Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to monitor feedback #794

Closed
oskar456 opened this issue Oct 10, 2019 · 11 comments
Closed

Add tool to monitor feedback #794

oskar456 opened this issue Oct 10, 2019 · 11 comments
Labels
good first issue help wanted issue:feature size:small 🐁

Comments

@oskar456
Copy link

@oskar456 oskar456 commented Oct 10, 2019

Problem you are facing

We've successfuly finished our first event using Pretalx. On the orga area dashboard, the last bullet is lit and its tooltip says that we should monitor incoming feedback.

Right now we have 80 talks. It is virtually impossible to monitor feedback in all the talks one by one.

Instead, I look directly into the database like this:

select review, title from submission_feedback f join submission_submission s on f.talk_id = s.id

Possible Solution

There should be a page summarising all incoming reviews for all talks.

@rixx
Copy link
Member

@rixx rixx commented Oct 10, 2019

Sounds like a good contribution for first-time contributors (or anybody else, of course).

@rixx rixx added good first issue help wanted issue:feature size:small 🐁 labels Oct 10, 2019
@michalpirchala
Copy link
Contributor

@michalpirchala michalpirchala commented Oct 11, 2019

Hello, I will grab this one. Can I have some additional info? What should it look like, what information sould be included etc.

@rixx
Copy link
Member

@rixx rixx commented Oct 11, 2019

I think the best thing to do would be to add a list of feedbacks received, as stated in the original ticket. It would be available to organisers in the same way the list of all submissions is available.

I'm not sure which level of information/guidance you are looking for, so feel free to ask for clarification!

@michalpirchala
Copy link
Contributor

@michalpirchala michalpirchala commented Oct 11, 2019

Is some demo database available? The system is pretty complex and as I need to go through complet event process, it would be nice to have already filled up data.

@rixx
Copy link
Member

@rixx rixx commented Oct 11, 2019

You can import another event's export by running the import_schedule command on their XML export. Any XML would do, for instance that of PyCon UK.

@michalpirchala
Copy link
Contributor

@michalpirchala michalpirchala commented Oct 17, 2019

Hello, so far I got this:
Screenshot from 2019-10-17 18-53-01

As I order feedbacks by talk.talk_id, they are "grouped" together and it is not necessary to have talk/submission title above every feedback. I would like to have the title just once and then all associated feedbacks to this talk. Normally I would do it in template cycle, comparing talk id to talk id in previous cycle. And if this changes, show new talk title. But this seems almost impossible in Django templating system, as it does not support assigning and changing variable values. Any tips?

You can check the commit here

@michalpirchala
Copy link
Contributor

@michalpirchala michalpirchala commented Oct 17, 2019

And maybe it should be sorted by id, so you can still easily check the latest feedback.

@rixx
Copy link
Member

@rixx rixx commented Oct 17, 2019

You should be able to iterate over talk.feedback.all in the template if you base the view on the Submission objects instead of the Feedback objects.

@michalpirchala
Copy link
Contributor

@michalpirchala michalpirchala commented Oct 18, 2019

But I will not be able to paginate over them and it will not be easy to monitor new feedback - I think that's the main point of this issue. So maybe we should order just by id to show the latest feedback at the top.

@rixx
Copy link
Member

@rixx rixx commented Oct 18, 2019

You could still order by the latest feedback entry, if you'd like, that's somewhat independent of the other question. Pagination and grouping usually goes hand in hand, though, so if you want to group by submission, you should also paginate by submission, imo. If you don't want to do that, you can of course first paginate by feedback, and then group by submission – it would be easiest to do that in the view, not in the template.

@rixx
Copy link
Member

@rixx rixx commented Dec 5, 2019

Closed via #798

@rixx rixx closed this Dec 5, 2019
rixx pushed a commit that referenced this issue Dec 5, 2019
rixx added a commit that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted issue:feature size:small 🐁
Projects
None yet
Development

No branches or pull requests

3 participants