-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Allow to configure a custom event domain #252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rixx
force-pushed
the
171-custom-domain
branch
5 times, most recently
from
November 9, 2017 20:43
df58360
to
f629ba4
Compare
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 87.82% 87.77% -0.06%
==========================================
Files 83 84 +1
Lines 4092 4204 +112
Branches 424 445 +21
==========================================
+ Hits 3594 3690 +96
- Misses 360 368 +8
- Partials 138 146 +8
|
rixx
force-pushed
the
171-custom-domain
branch
6 times, most recently
from
November 11, 2017 14:06
ba54413
to
c245c3f
Compare
rixx
force-pushed
the
171-custom-domain
branch
from
November 12, 2017 19:24
c245c3f
to
0e2510d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/references issue #171. It is still work in progress – the custom Url class has been added, now we need a settings field, and a middleware handling security concerns since we need to set
ALLOWED_HOSTS = ['*']
.We'll need pretty much everything the pretix
multidomain
app provides, so we should talk to @raphaelm if he things separating parts of it from pretix/core makes sense, or if we'll just carry code around as per usual.Checklist