Warn on second pretender #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trek
force-pushed
the
warn-on-second-pretender
branch
from
cfdf928
to
87dcbab
Compare
dustinfarris
added a commit
to dustinfarris/ember-cli-mirage
that referenced
this pull request
Oct 13, 2016
samselikoff
pushed a commit
to miragejs/ember-cli-mirage
that referenced
this pull request
Oct 13, 2016
|
@trek - This was released without a major version bump (as discussed in #165 (comment)) in 1.4.0... 😿 |
|
@trek Shouldn't the warning be a |
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Oct 17, 2016
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
|
@mariogintili @rwjblue I'm down to do a console.warn instead of throw an error release. I opted not to major bump because certain parts of Pretender (proxy and shutdown) will not work if you start a second server before shutting the first one down. It was the existing behavior but it's also a bug and doesn't follow the usage requirement we've had since the first release. I didn't know so many project still relied on this specific bug being left in place. |
Azdaroth
pushed a commit
to Azdaroth/ember-cli-mirage
that referenced
this pull request
Dec 4, 2016
samselikoff
pushed a commit
to miragejs/ember-cli-mirage
that referenced
this pull request
Dec 9, 2016
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Jan 5, 2017
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
acburdine
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Jan 5, 2017
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Jan 5, 2017
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
acburdine
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Jan 5, 2017
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #156 with a small change.