Skip to content

Commit

Permalink
Rename LogEntry.organizer_link to LogEntry.organizer (#3762)
Browse files Browse the repository at this point in the history
* Rename LogEntry.organizer_link to LogEntry.organizer

* isort fix
  • Loading branch information
raphaelm committed Dec 20, 2023
1 parent aa121b9 commit 4a49519
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 19 deletions.
2 changes: 1 addition & 1 deletion src/pretix/api/webhooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def register_default_webhook_events(sender, **kwargs):
def notify_webhooks(logentry_ids: list):
if not isinstance(logentry_ids, list):
logentry_ids = [logentry_ids]
qs = LogEntry.all.select_related('event', 'event__organizer', 'organizer_link').filter(id__in=logentry_ids)
qs = LogEntry.all.select_related('event', 'event__organizer', 'organizer').filter(id__in=logentry_ids)
_org, _at, webhooks = None, None, None
for logentry in qs:
if not logentry.organizer:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Generated by Django 4.2.4 on 2023-12-06 14:53

import django.db.models.deletion
from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("pretixbase", "0253_checkin_info"),
]

operations = [
migrations.AlterField(
model_name="logentry",
name="organizer_link",
field=models.ForeignKey(
db_column="organizer_link_id",
null=True,
on_delete=django.db.models.deletion.PROTECT,
to="pretixbase.organizer",
),
),
migrations.RenameField(
model_name="logentry",
old_name="organizer_link",
new_name="organizer",
),
]
2 changes: 1 addition & 1 deletion src/pretix/base/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def log_action(self, action, data=None, user=None, api_token=None, auth=None, sa
kwargs['api_token'] = api_token

logentry = LogEntry(content_object=self, user=user, action_type=action, event=event,
organizer_link_id=organizer_id, **kwargs)
organizer_id=organizer_id, **kwargs)
if isinstance(data, dict):
sensitivekeys = ['password', 'secret', 'api_key']

Expand Down
18 changes: 1 addition & 17 deletions src/pretix/base/models/log.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class LogEntry(models.Model):
device = models.ForeignKey('Device', null=True, blank=True, on_delete=models.PROTECT)
oauth_application = models.ForeignKey('pretixapi.OAuthApplication', null=True, blank=True, on_delete=models.PROTECT)
event = models.ForeignKey('Event', null=True, blank=True, on_delete=models.SET_NULL)
organizer_link = models.ForeignKey('Organizer', null=True, blank=True, on_delete=models.PROTECT)
organizer = models.ForeignKey('Organizer', null=True, blank=True, on_delete=models.PROTECT, db_column='organizer_link_id')
action_type = models.CharField(max_length=255)
data = models.TextField(default='{}')
visible = models.BooleanField(default=True)
Expand Down Expand Up @@ -123,22 +123,6 @@ def notification_type(self):
typepath = typepath.rsplit('.', 1)[0]
return no_type

@cached_property
def organizer(self):
from .organizer import Organizer

if self.organizer_link:
return self.organizer_link
elif self.event:
return self.event.organizer
elif hasattr(self.content_object, 'event'):
return self.content_object.event.organizer
elif hasattr(self.content_object, 'organizer'):
return self.content_object.organizer
elif isinstance(self.content_object, Organizer):
return self.content_object
return None

@cached_property
def display_object(self):
from . import (
Expand Down

0 comments on commit 4a49519

Please sign in to comment.