Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a styleguide #131

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Jun 5, 2019

this is a simplified list from the Solidity Style Guide made to help find the patterns still needed to be implemented.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #131 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   97.21%   96.98%   -0.24%     
==========================================
  Files          66       66              
  Lines         431      431              
  Branches       55       55              
==========================================
- Hits          419      418       -1     
- Misses         12       13       +1
Impacted Files Coverage Δ
src/clean.js 33.33% <0%> (-66.67%) ⬇️
src/nodes/BreakStatement.js 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd752a...ecbb713. Read the comment docs.

…ssary TODOs to be fully compliant.

Scenarios like function order or enforcing visibility in every function where not included as it is not a task for prettier.
@fvictorio
Copy link
Member

I don't mind merging this, but doesn't it sort-of duplicates the info in the github issues?

(For the record, I feel bad for saying this because this PR seems like it took some effort 🙁)

@Janther
Copy link
Contributor Author

Janther commented Jun 7, 2019

hehe the Github issues are just the outcome after having created this PR. The info is duplicated but in the PR we have also the tests ensuring that the style guide is being followed. Once we are fully compliant, I would suggest removing the STYLEGUIDE.md file and have a link to the Style Guide in the Solidity repo. but keep the tests and check from time to time if this document evolves and adapt to it.

@fvictorio
Copy link
Member

That makes sense to me!

@mattiaerre mattiaerre merged commit aea5ed8 into prettier-solidity:master Jun 11, 2019
@Janther Janther deleted the styleguide branch June 11, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants