replacing getValue on V3
#916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janther
force-pushed
the
deprecated-getValue
branch
from
31ab567
to
19e1c39
Compare
Janther
force-pushed
the
deprecated-getValue
branch
from
19e1c39
to
e927f70
Compare
Janther
force-pushed
the
deprecated-getValue
branch
from
e927f70
to
59a3d61
Compare
|
The Typescript migration will include this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
future proofing for V4
Caveat:
The optimal solution is to use
path.node()but there's a bug that I reported here prettier/prettier#15291.For now using
path.getNode().EDIT
I was informed that the proper way to call it was as a getter
path.nodeand not a function.