Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brackets when composing attribute/methods calls #112

Closed
mathieutu opened this issue Feb 23, 2018 · 2 comments
Closed

Remove brackets when composing attribute/methods calls #112

mathieutu opened this issue Feb 23, 2018 · 2 comments
Labels

Comments

@mathieutu
Copy link

-        return $this->quantity * $this->{self::PRICE_ATTRIBUTE};
+        return $this->quantity * $this->self::PRICE_ATTRIBUTE;
@czosel
Copy link
Collaborator

czosel commented Mar 8, 2018

Also:

$this->view->bar(
    $this->view->form->{$data['data-some-looooooooooooooooooooong-reference']}->getValue()
);

becomes

$this->view->bar(
    $this->view->form->$data['data-some-looooooooooooooooooooong-reference'
    ]->getValue()
);

This was referenced Mar 8, 2018
@czosel
Copy link
Collaborator

czosel commented Mar 10, 2018

Fixed in #183

@czosel czosel closed this as completed Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants