Fix dynamic propertylookup #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
force-pushed
the
curly-propertylookup
branch
from
45510de
to
2ee0626
Compare
|
is it worth considering doing this from the parent level instead of the child? ie when we print the property lookup, and |
|
@mgrip Of course, i can't believe i didn't notice that 馃槄 |
czosel
commented
Mar 9, 2018
| @@ -23,6 +23,6 @@ $encapsHereDoc2 = <<<STR | |||
| Hello foo $a bar | |||
| new line | |||
| STR; | |||
| $encapsedOffset = $a->bar$b; | |||
| $encapsedOffset = $a->{bar$b}; | |||
There was a problem hiding this comment.
Is $a->bar$b valid PHP?
There was a problem hiding this comment.
I don't think so, it seems to be a parse error in PHP7
php > $a = new stdClass;
php > $a->foobar = 1;
php > $b = 'bar';
php > echo $a->{"foo$b"};
1
php > echo $a->foo$b;
Parse error: syntax error, unexpected '$b' (T_VARIABLE), expecting ',' or ';' in php shell code on line 1
php > echo $a->{foo$b};
Parse error: syntax error, unexpected '$b' (T_VARIABLE) in php shell code on line 1
There was a problem hiding this comment.
馃憤 i'll remove it from the tests ... done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are probably many cases where this still breaks, but it might be an improvement anyway 馃槃
#112