Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Commit

Permalink
docs(contributing): Fix 'addContributor' example
Browse files Browse the repository at this point in the history
When adding myself as a contributor I followed these instructions and
tried `yarn start addContributor dsingleton`, which threw this error:

```
Scripts must resolve to strings. There is no script that can be resolved from "dsingleton" https://github.com/kentcdodds/nps/blob/v5.8.2/other/ERRORS_AND_WARNINGS.md#missing-script
error Command failed with exit code 1.
```

I'm not super familiar with `nps`, but i'm assuming it's taking
`<YOUR_GITHUB_USERNAME>` as an additional script, rather than input to
the `addContributor` script.

You get prompted to enter your username regardless, and the docs already
say to follow the prompts.
  • Loading branch information
dsingleton committed Mar 26, 2018
1 parent 44fade1 commit a77c219
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -20,7 +20,7 @@ This project follows the [all contributors][all-contributors] specification. To
contributors on the README.md, please use the automated script as part of your PR:

```console
yarn start addContributor <YOUR_GITHUB_USERNAME>
yarn start addContributor
```

Follow the prompt. If you've already added yourself to the list and are making a new type of contribution, you can run
Expand Down

0 comments on commit a77c219

Please sign in to comment.