Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Debug command returns undefined for package versions #217

Closed
darahak opened this issue Jun 30, 2017 · 2 comments
Closed

Debug command returns undefined for package versions #217

darahak opened this issue Jun 30, 2017 · 2 comments
Assignees
Labels

Comments

@darahak
Copy link
Collaborator

darahak commented Jun 30, 2017

Seen on recent issues.

Example:

Atom version: 1.18.0
prettier-atom version: undefined
prettier version: undefined
prettier-eslint version: undefined
prettier-atom configuration: {
  "formatOnSaveOptions": {
    "enabled": true,
    "respectEslintignore": true,
    "showInStatusBar": false,
    "javascriptScopes": [
      "source.js",
      "source.jsx",
      "source.js.jsx",
      "source.babel",
      "source.js-semantic",
      "text.html.basic",
      "text.html.vue"
    ],
    "typescriptScopes": [
      "source.ts",
      "source.tsx",
      "source.ts.tsx"
    ],
    "cssScopes": [
      "source.css",
      "source.less",
      "source.css.less",
      "source.scss",
      "source.css.scss"
    ],
    "excludedGlobs": [],
    "whitelistedGlobs": [],
    "isDisabledIfNotInPackageJson": false
  },
  "prettierEslintOptions": {
    "prettierLast": false
  },
  "prettierOptions": {
    "semi": false,
    "singleQuote": true,
    "bracketSpacing": true,
    "useTabs": false,
    "jsxBracketSameLine": false,
    "printWidth": 80,
    "tabWidth": "auto",
    "trailingComma": "none",
    "parser": "babylon"
  },
  "useEslint": true,
  "silenceErrors": false,
  "useEditorConfig": true
}
@darahak darahak added the bug label Jun 30, 2017
@darahak darahak self-assigned this Jun 30, 2017
@robwise
Copy link
Collaborator

robwise commented Jun 30, 2017

It would also be great if we could get:

  • local prettier version detected
  • local prettier-eslint version detected
  • local prettier-eslint-cli version detected

That way we could tell whether we are picking up their local dependency or not, although maybe this is out of scope for this issue.

@darahak
Copy link
Collaborator Author

darahak commented Jul 1, 2017

@robwise That's a good point. I'll open a separate issue so I can close this one with the bugfix.

darahak added a commit to darahak/prettier-atom that referenced this issue Jul 1, 2017
read-pkg and read-pkg-up do not have the same API.

Fixes prettier#217
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants