Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix(errors): handle errors that aren't syntax errors #240

Merged
merged 1 commit into from
Jul 22, 2017

Conversation

robwise
Copy link
Collaborator

@robwise robwise commented Jul 22, 2017

Previously, we were assuming all errors thrown during execution of the formatters were going to be
syntax errors. However, this is not the case, so we must handle these errors elegantly by displaying
them in a popup.

Resolves #231

Previously, we were assuming all errors thrown during execution of the formatters were going to be
syntax errors. However, this is not the case, so we must handle these errors elegantly by displaying
them in a popup.

Resolves #231
@robwise robwise merged commit 17d8668 into master Jul 22, 2017
@robwise robwise deleted the robwise/handle-non-syntax-errors branch July 22, 2017 23:35
@codecov-io
Copy link

Codecov Report

Merging #240 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage      76%   76.23%   +0.22%     
==========================================
  Files          26       26              
  Lines         421      425       +4     
  Branches       40       40              
==========================================
+ Hits          320      324       +4     
  Misses         87       87              
  Partials       14       14
Impacted Files Coverage Δ
src/executePrettier/handleError.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a9456...c3d02b0. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants