Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Fix tabWidth setting type #275

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Conversation

darahak
Copy link
Collaborator

@darahak darahak commented Sep 18, 2017

Fixes #241.

It was actually simpler than I thought, because Atom's JSON schema can accept multiple types for one setting and it handles priority.

@codecov-io
Copy link

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          29       29           
  Lines         458      458           
  Branches       45       45           
=======================================
  Hits          355      355           
  Misses         89       89           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2323193...21d1ca9. Read the comment docs.

Copy link
Collaborator

@robwise robwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robwise robwise merged commit e8702e9 into prettier:master Sep 18, 2017
@darahak darahak deleted the fix-tabwidth-type branch September 24, 2017 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants