Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement options page to persist Prettier config #56
Implement options page to persist Prettier config #56
Changes from 20 commits
8ebbda8
12deda1
8231626
f40c39d
d2fae29
f3cf1e5
41c4a62
e32c6c6
76ddfad
ebb4d42
bb80a9e
8064e58
9fe5a41
8d52005
735f598
1728726
fd15bff
cd3442c
cba3015
cc961b3
ba0e327
a86a9c8
aef9f04
18f9e91
0be7bd8
a7b312c
2bf6862
963090f
fd8150a
7b64d57
d0d1f36
ce0a44d
f357b7d
6e7f43e
11ee886
755268a
fdc53fa
d0ded2f
2c37194
111660e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessarily a blocker (we can fix this later if need be), but this only runs when the page is loaded, correct? One use case this might not handle very gracefully is when a GitHub/StackOverflow tab is open and someone goes and changes the settings (they wouldn't go into effect until the page is reloaded).
We could probably fix this by reading from chrome storage each time Prettier formats (again, does not need to be a blocker to land this, just want to make sure it's commented here for posterity).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to implement this, but we should be able to use
chrome.storage.onChanged.addListener
to subscribe to option updates in the content script.