Implement options page to persist Prettier config

[nickmccurdy]

Fixes #25

I still need to improve the UI, but feedback is welcome

[kaicataldo]

Thanks for working on this! Code mostly looks good to me, but I don't think this needs to be a completely separate app. Can we just update the webpack config to output a second bundle? We don't need to compile anything except JSX, I think, so adding and configuring Babel should be fairly straightforward.

[nickmccurdy]

I don't think this needs to be a completely separate app. Can we just update the webpack config to output a second bundle? We don't need to compile anything except JSX, I think, so adding and configuring Babel should be fairly straightforward.

I was originally hoping that CRA would make the build setup easier, but it's kind of a hassle to manually run two different build scripts depending on which files change. I'll give this a shot.

[nickmccurdy]

Travis seems to be stalling again, I don't even see these commits in the PR builds. 😢 Though oddly enough, the branch builds still work fine.

[lipis]

Seems to be OK now.. or?

[nickmccurdy]

I implemented a custom webpack config and moved the files around a bit. Do we like this setup? How would we feel about moving the contents of extension to the root and publishing dist instead so there aren't any extra files? Building and installing the extension is much faster without CRA's node_modules in the extension/options directory though.

[lipis]

let's make it work.. then make it better :)

[kaicataldo]

I think this is a good foundation for the settings page, and once we change this we could merge this and follow up with styling and moving files around!

[nickmccurdy]

Yea sorry, still working on that. I ran into some issues and set up devtools to make it easier to troubleshoot, but still need to finish tweaking its configuration.

[nickmccurdy]

Now that #59 is merged (which was an interactive rebase of this branch), should I merge or rebase this on top of master?

[lipis]

No need to rebase.. we are squashing the PRs anyways.

[nickmccurdy]

I figured out how to scope the options property in Chrome's extension storage. I can help out with publishing and UI fixes after this is merged.

[lipis]

I couldn't find a way to add more admins to the extension dashboard.. or how could I transfer it to another account so we can enable the automatic publishing.

[nickmccurdy]

To be clear, I don't need publishing access for this PR specifically, as the storage is automatically set up with the user's Chrome storage and Google account (if any) due to the storage permission in package.json.

If you want to set up group publishing see Set up Group Publishing. Unfortunately this process is irreversible and charges each new publisher $5, but we could try auto publishing with a single account if you prefer (which I think I would too).

[kaicataldo]

LGTM, thanks!

[kaicataldo]

This isn't necessarily a blocker (we can fix this later if need be), but this only runs when the page is loaded, correct? One use case this might not handle very gracefully is when a GitHub/StackOverflow tab is open and someone goes and changes the settings (they wouldn't go into effect until the page is reloaded).

We could probably fix this by reading from chrome storage each time Prettier formats (again, does not need to be a blocker to land this, just want to make sure it's commented here for posterity).

[nickmccurdy]

I forgot to implement this, but we should be able to use chrome.storage.onChanged.addListener to subscribe to option updates in the content script.

[lipis]

Published in 0.0.4