Improve development with webpack #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should revert this after upgrading to Prettier 1.19.
lipis
approved these changes
Oct 29, 2019
|
Thanks for the review. Should we get another before merging? Also please note that this removes the production build from CI, personally I don't think it's useful but I could add it back. |
kaicataldo
approved these changes
Oct 29, 2019
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #56 which only includes improvements to the webpack config so we can review them in isolation and potentially merge them sooner.
Most importantly,
yarnandyarn startshould be much faster, and some low priority warnings are hidden.