Migrate to Prettier v3

[sosukesuzuki]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
N/A

Describe the solution you'd like
A clear and concise description of what you want to happen.
N/A

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A

Additional context
Sorry ignoring the issue template..

Hi, I am a maintainer at Prettier.

The Prettier team is currently working on v3 (still alpha).
v3 will include breaking changes. (Detailed changelog is here: https://github.com/prettier/prettier/releases/tag/3.0.0-alpha.1)

For example, the all of public APIs will be async (changelog) and exported file structures are changed (changelog). prettier-vscode will probably affected by these changes.

If you have any questions, feel free to mention us. We can help you.

If you have already migrated to Prettier v3, sorry but please close this issue.

[kachkaev]

👋 @ntotten! If you need a test repo, feel free to use gicentre/prettier-plugin-elm. I bumped this project to Prettier 3.0.0-alpha.4 in gicentre/prettier-plugin-elm#36. Also using prettier-plugin-packagejson internally to keep dependencies sorted. This plugin gets picked up by V3 in CLI, just as before (yarn fix:prettier). VSCode formatting does nothing, probably because format returns a promise instead of a string.

[polRk]

Instead change the require of prettier.config.js in /Users/20265375/.vscode/extensions/esbenp.prettier-vscode-9.9.0/node_modules/prettier/third-party.js to a dynamic import() which is available in all CommonJS modules.

[Janther]

I'm developing on a project that is using 3.0.0-alpha.4 and this extension stopped working because of what @kachkaev said

VSCode formatting does nothing, probably because format returns a promise instead of a string.

it could also be that Prettier V3 uses ESM and Prettier V2 uses commonJs.

Maybe a quick fix for now could be to check the version of prettier installed in the local project, you could do it just by reading the package.json file first and if it's 3.0.0 just use the Prettier version in your extension until you fully support V3.

[kachkaev]

Maybe a quick fix for now could be to check the version of prettier installed in the local project

Not sure if there is a need for that. If a new version of VSCode extension uses await format(...), that should work for any version of Prettier. Using await notAPromise is OK.

[kachkaev]

#2947 by @sosukesuzuki is a step in this direction. It unlocks usage of Prettier v3 by the extension and should unblock folks why are using 3.0.0 alpha locally.

[ntotten]

This is shipped in the latest release.

[kachkaev]

@ntotten I guess that this issue is about using Prettier 3 internally, i.e. when local or global Prettier is not found. 9.12.0 adds support for Prettier 3, but does not embed Prettier 3 into the extension.

UPD Prettier 3 does not work in 9.12.0, see #2947 (comment) and below

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.