Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins & tools support for v3 #13616

Closed
17 of 23 tasks
sosukesuzuki opened this issue Oct 12, 2022 · 19 comments
Closed
17 of 23 tasks

Plugins & tools support for v3 #13616

sosukesuzuki opened this issue Oct 12, 2022 · 19 comments
Labels
area:plugin api locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself

Comments

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Oct 12, 2022

Prettier plugins interface will be breaking changed since v3.

So we need to investigate it works fine for major plugins.

Migration guide is here: https://github.com/prettier/prettier/wiki/How-to-migrate-my-plugin-to-support-Prettier-v3%3F

Plugins

Official Plugins

Community Plugins

Tools

@sosukesuzuki sosukesuzuki added the type:meta Issues about the status of Prettier, or anything else about Prettier itself label Oct 12, 2022
@sosukesuzuki sosukesuzuki changed the title Plugin investigation for v3 Plugins investigation for v3 Oct 12, 2022
@sosukesuzuki sosukesuzuki mentioned this issue Oct 12, 2022
23 tasks
@fisker fisker changed the title Plugins investigation for v3 Plugins & tools support for v3 Oct 20, 2022
@kachkaev kachkaev mentioned this issue Nov 4, 2022
11 tasks
@ssbarnea
Copy link

The fact that toml plugin is unmainted is a big issue for v3, as TOML if a very popular file format. This makes me wonder if that should not become part of core instead.

@fisker
Copy link
Member

fisker commented Apr 20, 2023

@ssbarnea Looking at the code, I think it should still work for v3. Have you try use it with Prettier v3? (we have released alpha version for v3)

@ssbarnea
Copy link

@fisker I have being using it with v3 alpha in few project, but today i found the first one where it raises an exception, so I had to drop it (had only one TOML file in entire repo).

@jasikpark
Copy link
Contributor

would love to see tamasfe/taplo#73 picked up as a replacement, since it seems like the most maintained formatter for toml atm?

@ssbarnea
Copy link

ssbarnea commented Apr 21, 2023

@jasikpark While it might be really good, I really doubt that npm based project like prettier will want to add a rust dependency. Usually tools like this do not go outside their own ecosystem, for good reasons.

On the other hand, I would not mind doing some maintenance for revival of the current toml plugin if the project would be adopted under prettier github organization. I have the feeling that the current owner, @bd82 would not mind such a move.

@sosukesuzuki @fisker @bd82 What do you think about this?

Related: un-ts/toml-tools#43

@bd82
Copy link
Contributor

bd82 commented Jun 4, 2023

Hello @ssbarnea I would be quite happy to hand-over the TOML plugin...
Particularly as I am no longer actively maintaining it 😄

@jasikpark
Copy link
Contributor

@sosukesuzuki
Copy link
Member Author

prettier-vscode v9.15.0 that supports Prettier v3 has been released

@jasikpark
Copy link
Contributor

also the fork @ianvs/prettier-plugin-sort-imports https://github.com/IanVS/prettier-plugin-sort-imports

@auvred
Copy link
Contributor

auvred commented Jul 11, 2023

@aronmal
Copy link

aronmal commented Jul 11, 2023

@mattrossman
Copy link

prettier-plugin-astro supports Prettier v3 as of v0.11.0

https://github.com/withastro/prettier-plugin-astro/releases/tag/v0.11.0

@so1ve
Copy link
Contributor

so1ve commented Jul 18, 2023

Though toml plugin is outdated, it still works when using prettier@3. (wow)

@dummdidumm
Copy link

prettier-plugin-svelte supports Prettier v3 as of v3.0.0

https://github.com/sveltejs/prettier-plugin-svelte

@NiklasPor
Copy link
Contributor

NiklasPor commented Jul 20, 2023

prettier-plugin-organize-attributes also now supports Prettier v3 😄

https://www.npmjs.com/package/prettier-plugin-organize-attributes

@NiklasPor
Copy link
Contributor

prettier-plugin-go-template >= 0.0.14 now also support Prettier v3 👁️

https://www.npmjs.com/package/prettier-plugin-go-template

@JounQin
Copy link
Member

JounQin commented Aug 2, 2023

prettier-plugin-toml >= 1.0.0 now supports Prettier v3

@ecmel
Copy link

ecmel commented Aug 3, 2023

prettier-plugin-ejs >= 0.0.14 supports Prettier v3

@fisker fisker unpinned this issue Aug 17, 2023
@fisker
Copy link
Member

fisker commented Aug 17, 2023

Most plugins listed already updated, closing now.

@fisker fisker closed this as completed Aug 17, 2023
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:plugin api locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests