Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade builtin Prettier to 3.x again #3142

Open
tats-u opened this issue Sep 12, 2023 · 6 comments
Open

Upgrade builtin Prettier to 3.x again #3142

tats-u opened this issue Sep 12, 2023 · 6 comments

Comments

@tats-u
Copy link

tats-u commented Sep 12, 2023 •
edited

Is your feature request related to a problem? Please describe.
Prettier 3 has been released but this extension pins it to 2.x due to #3099 #3098
I can't enable this extension globally due to prettier/prettier#6385. (I'm the author of prettier/prettier#11597)

Describe the solution you'd like
Upgrade builtin Prettier to 3.x again

Describe alternatives you've considered
Install Prettier 3.x or a backport plugin in every repositories

Additional context
@tats-u tats-u changed the title Bundle Prettier 3.x (instead of / with) 2.x Bundle Prettier 3.x (instead of / with 2.x) Sep 12, 2023
@tats-u tats-u changed the title Bundle Prettier 3.x (instead of / with 2.x) Bundle Prettier 3.x (instead of / not only 2.x) Sep 12, 2023
@tats-u tats-u changed the title Bundle Prettier 3.x (instead of / not only 2.x) Upgrade builtin Prettier to 3.x again Sep 12, 2023
@tats-u
Copy link
Author

tats-u commented Sep 14, 2023 •
edited

@ntotten Can you add pre-release version to test Prettier 3.x?

https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

@tats-u
Copy link
Author

tats-u commented Sep 16, 2023 •
edited

It's not too late after #3099.

@LukGer
Copy link

LukGer commented Nov 15, 2023

+1

@vincerubinetti vincerubinetti mentioned this issue Dec 18, 2023
Open
@github-actions GitHub Actions
Copy link

This issue has been labeled as stale due to inactivity. Reply to keep this issue open.

@github-actions github-actions bot added the Stale label Jan 15, 2024
@tats-u
Copy link
Author

tats-u commented Jan 15, 2024 •
edited

microsoft/vscode#201935

Can be fixed if this is fixed

@github-actions github-actions bot removed the Stale label Jan 16, 2024
@tats-u
Copy link
Author

tats-u commented Feb 29, 2024

Could someone try VS Code Insiders? It now supports ESM by upgrading Electron to 28.
The stable release will be available at the end of this month.

badeball added a commit to badeball/cypress-cucumber-preprocessor that referenced this issue Apr 28, 2024
@badeball
Update* all dependencies, including @cucumber/messages
47c8fbf 
* Nearly all, except some packages that have migrated to ESM and are
  more diffult to update, in addition to

  - eslint, for which typescript-eslint doesn't support yet [1[, and
  - prettier, for which the associated extension remains behind [2]

This fixes #1180 [3].

[1] typescript-eslint/typescript-eslint#8211
[2] prettier/prettier-vscode#3142
[3] #1180
badeball added a commit to badeball/cypress-cucumber-preprocessor that referenced this issue Apr 28, 2024
@badeball
Update* all dependencies, including @cucumber/messages
531839b 
* Nearly all, except some packages that have migrated to ESM and are
  more diffult to update, in addition to

  - eslint, for which typescript-eslint doesn't support yet [1[, and
  - prettier, for which the associated extension remains behind [2]

This fixes #1180 [3].

[1] typescript-eslint/typescript-eslint#8211
[2] prettier/prettier-vscode#3142
[3] #1180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tats-u @LukGer