fix "editor.formatOnSaveMode": "modifications"

[rotu]

fix #630
fix #1562
fix #1677
fix #2295
fix #2330

• Run tests
• Update the CHANGELOG.md with a summary of your changes

[rotu]

@ntotten could you review this? It’s a significant QoL improvement.

[ntotten]

This looks great, can you add some tests though and then I will get it merged.

[rotu]

I didn't add a test that actually relies on an SCM, but I did add one for formatting multiple ranges, which should test the same code paths.

In the process, I also discovered a bug in Prettier: prettier/prettier#12540

[ntotten]

Awesome. Thanks!

[rotu]

D'oh! I committed some junk which caused the test to break. Could you try that again please?

[nickqi-tubi]

That's great improvement. However, I tested the latest v9.5.0, it seems only formatting the modified lines doesn't work.. I'm using the latest VS Code, which is version 1.66.2. Can you double check for that?

[rotu]

@nickqi-tubi what's the file type?

[nickqi-tubi]

Hi @rotu , the file type is .ts

[rotu]

Hi @rotu , the file type is .ts

Well, that wrecks my main theory. Maybe you could see if you can reproduce the issue in the prettier web playground? https://prettier.io/playground/