New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plugins parser
not inferred
#3027
Conversation
After confirmation, it was found that the reason for the failure of the following two tests was due to the existence of
In addition, because I use https://github.com/u3u/prettier-vscode/actions/runs/5269104746/jobs/9526747643 prettier-vscode/.github/workflows/main.yml Lines 13 to 20 in 03bbcc6
|
1618987
to
5dce927
Compare
Looks pretty good, there is one test failing though. Can you take a look? |
@ntotten Hi, this is a bit strange. All tests passed before you merged the All passed: https://github.com/prettier/prettier-vscode/actions/runs/5302709062/jobs/9600483439 The failed test is "it formats by Prettier v3", which should not be related to my changes. And now there are strange errors in the |
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # CHANGELOG.md
run `corepack prepare pnpm@7.33.1 --activate`
https://github.com/u3u/prettier-vscode/actions/runs/5330997873 To pass the "it formats by Prettier v3" test when using pnpm 7, |
Fixed #3026
Upgrade PNPM version tov8
After runningyarn test
without changing anything locally, I had 2 test failures. But I don't know why. Is it a problem with my local environment?CHANGELOG.md
with a summary of your changes