Fixes resolveConfigFile usage for 3.1.1
#3335
Conversation
src/ModuleResolver.ts
Outdated
| // Avoid https://github.com/prettier/prettier/pull/15363 | ||
| const isGte3_1_1 = semver.gte(prettierInstance.version, "3.1.1"); | ||
| if (isGte3_1_1) { | ||
| return path.join(fileName, "tmp"); |
There was a problem hiding this comment.
@fisker fileName is opened project directory path. And it has temporary file name. Do you have a better plan?
There was a problem hiding this comment.
Perhaps a more random name, such as UUID, should be used?
There was a problem hiding this comment.
Can't we use the real file path?
There was a problem hiding this comment.
Prettier use noop.js for import from directory https://github.com/prettier/prettier/blob/41baabd62734a4b8f4065294cad873af3b46dbb3/src/utils/import-from-directory.js#L6
There was a problem hiding this comment.
Can't we use the real file path?
Maybe it can be done, but I'm not familiar with prettier-vscode and don't know what the expected behavior is...
So I thought it would be quicker if we could take an approach like this PR.
There was a problem hiding this comment.
I've updated to use noop.js instead of tmp.
There was a problem hiding this comment.
I'm not familiar with this, you can merge if you think it will work, but better wait for @ntotten ?
|
Having the same issue with prettier 2.5.0. Trying to format svelte.ts files and getting "Extension 'Prettier - Code formatter' is configured as formatter but it cannot format 'Svelte'-files. This is my package.json: |
|
I'm also encountering this problem, with the same setup as @Synweigh |
Fixes #3235
CHANGELOG.mdwith a summary of your changes