Support Prettier <1.8.0 for getSupportInfo #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHilker
force-pushed
the
support-older-prettier
branch
from
e150eaa
to
2357ad7
Compare
Closed
|
Seems fixed upstream. Thanks! |
CiGit
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * Support Prettier <1.8.0 for getSupportInfo (#707) * feat: hide statusBarItem for disabled languages (#733) * Resolve prettier to bundled if findPkg can't find it (#811) Fixes #522 Slightly different implementation of #561 * Update .vscodeignore Add .github folder * Create bare-bones pull request template (#708) * Create bare-bones pull request template This template almost certainly needs fleshing out, but I figured a good place to start was making sure people run tests and making sure they update the Changelog. * Create separate .github folder for issue/pr templates * add support for quoteProps * Support prettier 1.17 * Update in reaction to new VS code feature to prompt when multiple formatters are installed * add support for quoteProps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick followup to #706 (comment)
Connected to #710
This adds a fallback to
bundledPrettier.getSupportInfoifprettierInstance.getSupportInfois undefined. Currently this will still have thebabel/babylonparser issue of #705, but this will be necessary once that's fixed upstream.