Ignore .gitignored files (#14731)

changelog_unreleased/cli/14731.md

@@ -0,0 +1,8 @@
+#### [Breaking] Ignore `.gitignore`d files by default (#14731 by @fisker)
+
+Prettier ignores files ignored by `.gitignore` by default.
+If you want the old behavior(only ignore files ignored by `.prettierignore`), use
+
+```console
+prettier . --write --ignore-path=.prettierignore
+```

cspell.json

@@ -62,6 +62,7 @@
         "concat",
         "concating",
         "cond",
+        "customignore",
         "daleroy",
         "danez",
         "Dara",

scripts/tools/eslint-plugin-prettier-internal-rules/await-cli-tests.js

@@ -31,6 +31,18 @@ module.exports = {
           return;
         }
 
+        // wrapped
+        // `const runCliWithoutGitignore = () => runCli()`
+        // `const runCliWithoutGitignore = () => { return runCli() }`
+        if (
+          (parent.type === "ArrowFunctionExpression" &&
+            parent.body === callExpression) ||
+          (parent.type === "ReturnStatement" &&
+            parent.argument === callExpression)
+        ) {
+          return;
+        }
+
         if (
           parent.type === "MemberExpression" &&
           parent.object === callExpression &&

src/cli/cli-options.evaluate.js

@@ -195,7 +195,7 @@ const options = {
   ignorePath: {
     array: true,
     category: optionCategories.CATEGORY_CONFIG,
-    default: [{ value: [".prettierignore"] }],
+    default: [{ value: [".gitignore", ".prettierignore"] }],
     description: outdent`
       Path to a file with patterns describing files to ignore.
       Multiple values are accepted.

tests/integration/__tests__/__snapshots__/early-exit.js.snap

@@ -112,7 +112,7 @@ Config options:
                            Find and print the path to a configuration file for the given input file.
   --ignore-path <path>     Path to a file with patterns describing files to ignore.
                            Multiple values are accepted.
-                           Defaults to [.prettierignore].
+                           Defaults to [.gitignore, .prettierignore].
   --plugin <path>          Add a plugin. Multiple plugins can be passed as separate \`--plugin\`s.
                            Defaults to [].
   --plugin-search-dir <path>
@@ -283,7 +283,7 @@ Config options:
                            Find and print the path to a configuration file for the given input file.
   --ignore-path <path>     Path to a file with patterns describing files to ignore.
                            Multiple values are accepted.
-                           Defaults to [.prettierignore].
+                           Defaults to [.gitignore, .prettierignore].
   --plugin <path>          Add a plugin. Multiple plugins can be passed as separate \`--plugin\`s.
                            Defaults to [].
   --plugin-search-dir <path>

tests/integration/__tests__/__snapshots__/file-info.js.snap

@@ -54,14 +54,14 @@ exports[`extracts file-info with ignored=true for a file in .prettierignore (std
 
 exports[`extracts file-info with ignored=true for a file in .prettierignore (write) 1`] = `[]`;
 
-exports[`extracts file-info with ignored=true for a file in a hand-picked .prettierignore (stderr) 1`] = `""`;
+exports[`extracts file-info with ignored=true for a file in a hand-picked ignore file (stderr) 1`] = `""`;
 
-exports[`extracts file-info with ignored=true for a file in a hand-picked .prettierignore (stdout) 1`] = `
+exports[`extracts file-info with ignored=true for a file in a hand-picked ignore file (stdout) 1`] = `
 "{ "ignored": true, "inferredParser": null }
 "
 `;
 
-exports[`extracts file-info with ignored=true for a file in a hand-picked .prettierignore (write) 1`] = `[]`;
+exports[`extracts file-info with ignored=true for a file in a hand-picked ignore file (write) 1`] = `[]`;
 
 exports[`extracts file-info with inferredParser=foo when a plugin is hand-picked (stderr) 1`] = `""`;
 

tests/integration/__tests__/__snapshots__/help-options.js.snap

@@ -251,7 +251,7 @@ exports[`show detailed usage with --help ignore-path (stdout) 1`] = `
   Path to a file with patterns describing files to ignore.
   Multiple values are accepted.
 
-Default: [.prettierignore]"
+Default: [.gitignore, .prettierignore]"
 `;
 
 exports[`show detailed usage with --help ignore-path (write) 1`] = `[]`;