Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore .gitignored files #14731

Merged
merged 13 commits into from
May 4, 2023
Merged

Ignore .gitignored files #14731

merged 13 commits into from
May 4, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 20, 2023

Description

Fixes #14115

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker added this to the 3.0 milestone Apr 21, 2023
@fisker fisker marked this pull request as ready for review April 21, 2023 10:44
@fisker fisker mentioned this pull request Apr 21, 2023
Closed
@fisker
Copy link
Member Author

fisker commented Apr 22, 2023

I'm going to wait for #14627, since we'll need update once it land, and I don't want ask the author to make the change.

@rotu
Copy link
Contributor

rotu commented May 1, 2023

I think this should be reworked to not use .gitignore as a second .eslintignore: #14115 (comment)

@fisker
Copy link
Member Author

fisker commented May 4, 2023

I think this should be reworked to not use .gitignore as a second .eslintignore: #14115 (comment)

I think we'll go with this approach for now. See #14115 (comment)

@fisker fisker merged commit b86e42c into prettier:main May 4, 2023
27 checks passed
@fisker fisker deleted the gitignore branch May 4, 2023 09:20
@sosukesuzuki sosukesuzuki mentioned this pull request May 17, 2023
Closed
@risu729 risu729 mentioned this pull request Jul 8, 2023
Merged
4 tasks
@karlhorky karlhorky mentioned this pull request Jul 15, 2023
Merged
1 task
@drgarlic drgarlic mentioned this pull request Aug 16, 2023
Merged
mnvr added a commit to mnvr/mrmr.io that referenced this pull request Sep 25, 2023
@mnvr
yarn upgrade prettier@^3.0.3
846cded 
- The default value of trailingComma has been changed to "all".

- Ignore .gitignored files by default (prettier/prettier#14731)
@ethanjdiamond ethanjdiamond mentioned this pull request Oct 14, 2023
Open
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
@fisker @medikoo
Ignore .gitignored files (prettier#14731)
d8fe183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachkaev kachkaev kachkaev left review comments

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Ignore files that are not tracked by git (by default)
4 participants
@fisker @rotu @kachkaev @sosukesuzuki