Merge pull request #126 from vjeux/jsx_quotes

Always use double quotes for JSX and properly escape

src/printer.js

@@ -1044,8 +1044,18 @@ function genericPrintNoParens(path, options, print) {
   case "JSXAttribute":
     parts.push(path.call(print, "name"));
 
-    if (n.value)
-      parts.push("=", path.call(print, "value"));
+    if (n.value) {
+      let res;
+      if (
+        (n.value.type === 'StringLiteral' || n.value.type === 'Literal') &&
+        typeof n.value.value === 'string'
+      ) {
+        res = '"' + util.htmlEscapeInsideDoubleQuote(n.value.value) + '"';
+      } else {
+        res = path.call(print, "value");
+      }
+      parts.push("=", res);
+    }
 
     return concat(parts);
   case "JSXIdentifier":

src/util.js

@@ -311,3 +311,16 @@ function setLocEnd(node, index) {
   }
 }
 util.setLocEnd = setLocEnd;
+
+// http://stackoverflow.com/a/7124052
+function htmlEscapeInsideDoubleQuote(str) {
+  return str
+    .replace(/&/g, '&')
+    .replace(/"/g, '"');
+// Intentionally disable the following since it is safe inside of a
+// double quote context
+//    .replace(/'/g, ''')
+//    .replace(/</g, '&lt;')
+//    .replace(/>/g, '&gt;');
+}
+util.htmlEscapeInsideDoubleQuote = htmlEscapeInsideDoubleQuote;

tests/jsx/__snapshots__/jsfmt.spec.js.snap

@@ -0,0 +1,10 @@
+exports[`test quotes.js 1`] = `
+"<div id=\"&quot;\'<>&amp;quot;\" />;
+<div id=\'\"&#39;<>&amp;quot;\' />;
+<div id={\'\\\'\"&quot;<>&amp;quot;\'} />;
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+<div id=\"&quot;\'<>&amp;quot;\" />;
+<div id=\"&quot;\'<>&amp;quot;\" />;
+<div id={\"\'\\\"&quot;<>&amp;quot;\"} />;
+"
+`;

tests/jsx/jsfmt.spec.js

@@ -0,0 +1 @@
+run_spec(__dirname);

tests/jsx/quotes.js

@@ -0,0 +1,3 @@
+<div id="&quot;'<>&amp;quot;" />;
+<div id='"&#39;<>&amp;quot;' />;
+<div id={'\'"&quot;<>&amp;quot;'} />;