Always use double quotes for JSX and properly escape #126
Conversation
JSX quotes are unfortunately using html escaping. Also, we should disregard the single-quote option for JSX quotes as we always want double quotes.
| // http://stackoverflow.com/a/7124052 | ||
| function htmlEscapeInsideDoubleQuote(str) { | ||
| return str | ||
| .replace(/&/g, '&') |
There was a problem hiding this comment.
Why are we doing this in the formatter? Won't this continually replace the & in & if you successively print a file multiple times?
There was a problem hiding this comment.
The parser unescapes the string. So if you write <div id="&" />, str here will be & and not &
There was a problem hiding this comment.
It does?! I'm confused! In JavaScript "&" is just a normal string value, it doesn't mean anything until it touches the DOM right?
There was a problem hiding this comment.
JSX was supposed to be HTML in JS so it borrowed the HTML escaping format for strings literals. This is somethint that we are not happy about and if we are ever doing jsx2 we'll fix this. Until then we have to live with it
lock
bot
added
the
locked-due-to-inactivity
JSX quotes are unfortunately using html escaping. Also, we should disregard the single-quote option for JSX quotes as we always want double quotes.