Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious ? added for yaml example #5000

Closed
vjeux opened this issue Aug 21, 2018 · 3 comments
Closed

Spurious ? added for yaml example #5000

vjeux opened this issue Aug 21, 2018 · 3 comments
Assignees
@ikatyang
Labels
lang:yaml Issues affecting YAML locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:duplicate Issues that are a duplicate of a previous issue

Comments

@vjeux
Copy link
Contributor

vjeux commented Aug 21, 2018

Prettier 1.14.2
Playground link

--parser yaml

Input:

metadata:
    name: greeter-svc-request
spec:

Output:

metadata:
  name: greeter-svc-request
? spec

This was reported by @peterj prettier/prettier-vscode#560
@vjeux vjeux added priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! lang:yaml Issues affecting YAML labels Aug 21, 2018
@ikatyang
Copy link
Member

#4972 😉

Prettier pr-4972
Playground link

--parser yaml

Input:

metadata:
    name: greeter-svc-request
spec:

Output:

metadata:
  name: greeter-svc-request
spec:

@ikatyang ikatyang marked this as a duplicate of #4971 Aug 21, 2018
@ikatyang ikatyang added type:duplicate Issues that are a duplicate of a previous issue and removed priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! labels Aug 21, 2018
@ikatyang
Copy link
Member

(It's the syntax for explicit keys.)

@vjeux
Copy link
Contributor Author

vjeux commented Aug 21, 2018

So fast, so furious!

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ikatyang ikatyang

Labels
lang:yaml Issues affecting YAML locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:duplicate Issues that are a duplicate of a previous issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjeux @ikatyang