Fix comment sorting location #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's only doing one test for begin/end, but in the issue prettier#1037, we have two nodes that have the same start but different end. The current implementation incorrectly sorts them and the identifier ends up being before the container and therefore the comment search doesn't recurse into it. Fixes prettier#1037
vjeux
commented
Mar 19, 2017
| @@ -13,8 +13,7 @@ const { a /* comment */ = 1 } = b; | |||
| const { c = 1 /* comment */ } = d; | |||
|
|
|||
| let { | |||
| //comment | |||
| a = b | |||
| a = b //comment | |||
There was a problem hiding this comment.
It was
let {a //comment
= b} = cso both before and after are okay.
| declare module bar { | ||
| // TODO |
There was a problem hiding this comment.
The input is
// This file triggers a violation of the "disjoint-or-nested ranges invariant"
// that we implicitly assume in type-at-pos and coverage implementations. In
// particular, when unchecked it causes a crash with coverage --color.
declare module foo {
}
declare module bar {
}
// TODOso while not perfect, the new behavior is much better.
| } | ||
| /** | ||
|
|
||
| /** |
There was a problem hiding this comment.
The flow parser has completely busted parsing location for this one. It happened to do the right thing in the previous version by chance.
There was a problem hiding this comment.
There was a problem hiding this comment.
Haha, have you filed a bug with Flow?
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| type Foo = { | ||
| method( | ||
| arg: number, // I belong with baz |
There was a problem hiding this comment.
now it doesn't inline the method anymore!
This was referenced Mar 19, 2017
|
Very nice catch! I'll approve and let you merge in case you want to do anything else |
jlongster
approved these changes
Mar 20, 2017
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's only doing one test for begin/end, but in the issue #1037, we have two nodes that have the same start but different end. The current implementation incorrectly sorts them and the identifier ends up being before the container and therefore the comment search doesn't recurse into it.
Fixes #1037
Fixes #938