Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment sorting location #1038

Merged
merged 1 commit into from Mar 20, 2017
Merged

Fix comment sorting location #1038

merged 1 commit into from Mar 20, 2017

Commits on Mar 19, 2017

  1. Fix comment sorting location 

    Right now it's only doing one test for begin/end, but in the issue prettier#1037, we have two nodes that have the same start but different end. The current implementation incorrectly sorts them and the identifier ends up being before the container and therefore the comment search doesn't recurse into it.

Fixes prettier#1037
    @vjeux
    vjeux committed Mar 19, 2017
    Copy the full SHA
    1a80fd9 View commit details
    Browse the repository at this point in the history