Change default value of trailingComma to "all"
#11479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fisker Can you respond as to whether you are going to work on this PR? Support for Internet Explorer, the only browser lacking an update for modern trailing comma support, has ended on June 15, 2022. |
|
You can still set We'll update snapshots and merge before v3 release, it's a simple PR. |
4 tasks
# Conflicts: # tests/format/angular/angular/jsfmt.spec.js # tests/format/flow/function-parentheses/jsfmt.spec.js # tests/format/flow/generic/jsfmt.spec.js # tests/format/flow/object-order/jsfmt.spec.js # tests/format/flow/parameter-with-type/jsfmt.spec.js # tests/format/graphql/trailing-comma/jsfmt.spec.js # tests/format/js/arrow-call/jsfmt.spec.js # tests/format/js/destructuring-ignore/jsfmt.spec.js # tests/format/js/object-property-ignore/jsfmt.spec.js # tests/format/js/strings/jsfmt.spec.js # tests/format/js/trailing-comma/jsfmt.spec.js # tests/format/json/json/jsfmt.spec.js # tests/format/json/with-comment/jsfmt.spec.js # tests/format/lwc/lwc/jsfmt.spec.js # tests/format/misc/json-unknown-extension/jsfmt.spec.js # tests/format/scss/map/jsfmt.spec.js # tests/format/scss/scss/jsfmt.spec.js # tests/format/scss/trailing-comma/jsfmt.spec.js # tests/format/typescript/angular-component-examples/jsfmt.spec.js # tests/format/typescript/interface2/jsfmt.spec.js # tests/format/typescript/tuple/jsfmt.spec.js # tests/format/vue/custom_block/jsfmt.spec.js # tests/format/vue/vue/jsfmt.spec.js
This comment was marked as outdated.
This comment was marked as outdated.
|
For reviewers , use this link instead of click the |
fisker
changed the title
trailingComma default value to "all"trailingComma to "all"
# Conflicts: # tests/format/js/strings/__snapshots__/jsfmt.spec.js.snap # tests/format/js/strings/jsfmt.spec.js
nickmccurdy
approved these changes
Jul 23, 2022
sosukesuzuki
approved these changes
Jul 31, 2022
# Conflicts: # tests/format/js/strings/jsfmt.spec.js
2 tasks
1 task
github-merge-queue bot
pushed a commit
to microsoft/qsharp
that referenced
this pull request
Oct 27, 2023
Updated all direct npm dependencies to `@latest`. Observed changes: - Prettier: now adds trailing commas to all lists. prettier/prettier#11479 - Katas: `marked` now omits `id` attributes for header tags (confirmed benign) markedjs/marked#2890 - Other trivial differences in JS emit through `esbuild`. I was really hoping this would be a trivial process, but sadly it wasn't. For posterity, here's what the process ended up being: ```js const { execSync } = require("node:child_process"); function run(command) { console.log(`running command ${command}`); return execSync(command); } const deps = JSON.parse(run(`npm ls --package-lock-only --json`)); // Do these in this order first, otherwise @typescript-eslint/eslint-plugin // gets really upset about the peer dependency missing run("npm install @typescript-eslint/parser@latest"); run("npm install @typescript-eslint/eslint-plugin@latest"); // Update all direct deps to @latest for (const depName of Object.keys(deps.dependencies)) { if (!depName.startsWith("qsharp")) { run(`npm install ${depName}@latest`); } } // Update indirect deps in package-lock.json run("npm update"); // This fixes the workspace names in package-lock.json, // which for some reason get erased above run("npm install"); ``` Ran `./build.py` to confirm the repo still built, discovered formatting changes. To reformat with new Prettier defaults: ```bash npm run prettier:fix ``` Since we pulled a lot of JS tooling updates, I ran a quick script to save the built artifacts so I could diff the JS output: ```bash #!/bin/bash set -e # clean repo git clean -fdx rm -rf baseline-compare/ mkdir baseline-compare # build ./build.py --wasm --npm --vscode --no-check --no-test # npm mkdir -p baseline-compare/npm pushd npm npm pack --pack-destination . popd tar -xzf npm/qsharp-lang-0.0.0.tgz -C baseline-compare/npm # vsix npm install -g @vscode/vsce pushd vscode vsce package --pre-release popd unzip vscode/qsharp-lang-vscode-dev-0.0.0.vsix -d baseline-compare/vscode # commit baseline cp package-lock.json baseline-compare/ git add baseline-compare/ git commit -m "Baseline for $(git rev-parse HEAD)" ``` Ran this script first on `main`, then with the updated `package.json` & `package-lock.json`. Used `git` to diff the `baseline-compare` changes. Confirmed they looked harmless.
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #6963, set
trailingCommadefault value to"all", closes #11465Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨