Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value for trailingComma to "all" in v3 #11465

Closed
fisker opened this issue Sep 8, 2021 · 5 comments
Closed

Change the default value for trailingComma to "all" in v3 #11465

fisker opened this issue Sep 8, 2021 · 5 comments
Labels
status:needs discussion Issues needing discussion and a decision to be made before action can be taken
Milestone
3.0

Comments

@fisker
Copy link
Member

fisker commented Sep 8, 2021

Trailing commas in function syntax was introduced in ES2017, it's supported since Node.js 8.2.1, modern browsers supports it too.

I think it's time to change trailingComma to "all".
@fisker fisker added the status:needs discussion Issues needing discussion and a decision to be made before action can be taken label Sep 8, 2021
@sosukesuzuki
Copy link
Member

👍

@alexander-akait
Copy link
Member

Agree

@kachkaev
Copy link
Member

kachkaev commented Sep 8, 2021

"trailingComma": "all" is the only option in my shared prettier config, so a big 👍 from me too 😁

@kt3k kt3k mentioned this issue Sep 9, 2021
Closed
@fisker fisker mentioned this issue Sep 9, 2021
Merged
4 tasks
This was referenced Sep 22, 2021
Closed
Closed
@kachkaev kachkaev added this to the 3.0 milestone Feb 1, 2022
@nickmccurdy
Copy link
Member

nickmccurdy commented Jun 12, 2022 •
edited

Support for Internet Explorer, the only browser lacking an update for modern trailing comma support, has ended.

Edited since the end of support date (June 15, 2022) has passed.

@sosukesuzuki sosukesuzuki mentioned this issue Jul 20, 2022
Closed
4 tasks
@fisker
Copy link
Member Author

fisker commented Aug 1, 2022

Fixed in #11479

@fisker fisker closed this as completed Aug 1, 2022
dcastil added a commit to dcastil/tailwind-merge that referenced this issue Aug 20, 2022
@dcastil
Change prettier config trailingComma to all
52acec1 
Prettier is setting it as the default in v3
https://github.com/prettier/prettier/releases/tag/3.0.0-alpha.0
prettier/prettier#11465
@fisker fisker mentioned this issue Dec 1, 2022
Merged
@keithamus keithamus mentioned this issue Dec 1, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:needs discussion Issues needing discussion and a decision to be made before action can be taken
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
5 participants
@fisker @kachkaev @nickmccurdy @alexander-akait @sosukesuzuki