2.6 blog post #12412

sosukesuzuki · 2022-03-07T14:18:53Z

Description

https://deploy-preview-12412--prettier.netlify.app/blog/2022/03/15/2.6.0.html

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

kachkaev · 2022-03-08T12:09:19Z

I’ve just looked a blog post on TypeScript 4.6 — it does not seem to have any new syntax. How about mentioning this anyhow in the blog? We usually release a new minor version of Prettier after a new TypeScript release to support new syntax. If we don't say anything, some folks may think that we’ve forgotten about TS 4.6 and will go checking TS blog themselves.

changelog_unreleased/blog-post-intro.md

j-f1 · 2022-03-13T12:14:02Z

website/blog/2022-03-13-2.6.0.md

+  };
+```
+
+And for TS that comment would not be stable with a second format:


Suggested change

And for TS that comment would not be stable with a second format:

This change also fixes an issue where a similarly-placed comment in TypeScript would be moved again after a second formatting operation:

(still not 100% happy with this wording but I think it might be clearer)

website/blog/2022-03-13-2.6.0.md

j-f1 · 2022-03-13T12:36:51Z

scripts/draft-blog-post.mjs

@@ -49,6 +49,7 @@ const categories = [
  { dir: "yaml", title: "YAML" },
  { dir: "api", title: "API" },
  { dir: "cli", title: "CLI" },
+  { dir: "others", title: "Others" },


Suggested change

{ dir: "others", title: "Others" },

{ dir: "other", title: "Other" },

ooh misc/“Miscellaneous” is good too!

changelog_unreleased/others/12055.md

changelog_unreleased/typescript/12400.md

sosukesuzuki · 2022-03-13T13:24:13Z

@j-f1 Thanks for all the your reviews, every time! It is really helpful.

changelog_unreleased/typescript/12390.md

website/blog/2022-03-13-2.6.0.md

fisker · 2022-03-14T01:55:03Z

changelog_unreleased/blog-post-intro.md

@@ -8,6 +8,6 @@ This release includes a new `singleAttributePerLine` option. This is an option t

 We've also added support formatting for some new JavaScript syntax proposals via Babel.

-If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel).
+If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to [LINE](https://line.me/en/) and [Ubie](https://ubie.life/en) for actually sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/).


Suggested change

If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to [LINE](https://line.me/en/) and [Ubie](https://ubie.life/en) for actually sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/).

If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to some amazing sponsors such as [LINE Corporation](https://opencollective.com/line), [Airbnb](https://opencollective.com/airbnb), [Nx (by Nrwl)](https://opencollective.com/nx), [Ubie](https://opencollective.com/ubie-inc), and many others for sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/).

Let's link to their opencollective account?

I don't think we should link to their OpenCollective. This is because the company that sponsored us would want us to see the company's website rather than the OpenCollective link.

They have their production links on OpenCollective account.

Anyway, can you add "Airbnb" and "Nx"? They are doing generous donation monthly.

Anyway, can you add "Airbnb" and "Nx"? They are doing generous donation monthly.

Sure!

Btw, as you mentioned in Discord, I think we should add sponsors in our website.

sosukesuzuki · 2022-03-14T02:50:52Z

@j-f1 Could you review blog-post-intro.md again?

j-f1

Last few small tweaks, otherwise LGTM!

scripts/draft-blog-post.mjs

website/blog/2022-03-14-2.6.0.md

fisker

Good job!

changelog_unreleased/blog-post-intro.md

fisker · 2022-03-15T04:39:25Z

scripts/draft-blog-post.mjs

@@ -74,7 +84,7 @@ fs.writeFileSync(
  replaceVersions(
    [
      fs.readFileSync(introFile, "utf8").trim(),
-      "<!--truncate-->",
+      shouldPrintTruncate ? "<!--truncate-->" : "",


Why not check if blog-post-intro.md contains 

Thanks! 17ba6d8

kachkaev · 2022-03-15T15:25:05Z

Let’s rename the file:

-website/blog/2022-03-15-2.6.0.md
+website/blog/2022-03-16-2.6.0.md

Based on: #12410 (comment)

Co-authored-by: Jed Fox <git@jedfox.com>

Co-authored-by: Alexander Kachkaev <alexander@kachkaev.ru>

sosukesuzuki mentioned this pull request Mar 7, 2022

Release 2.6 #12410

Closed

11 tasks

sosukesuzuki marked this pull request as ready for review March 13, 2022 08:24

sosukesuzuki requested review from fisker, j-f1 and kachkaev March 13, 2022 08:32

j-f1 reviewed Mar 13, 2022

View reviewed changes

changelog_unreleased/typescript/12390.md Outdated Show resolved Hide resolved

fisker reviewed Mar 13, 2022

View reviewed changes

website/blog/2022-03-13-2.6.0.md Outdated Show resolved Hide resolved

fisker reviewed Mar 14, 2022

View reviewed changes

sosukesuzuki force-pushed the blog-post-2.6 branch from 1739493 to 1ea4630 Compare March 14, 2022 13:53

j-f1 approved these changes Mar 14, 2022

View reviewed changes

scripts/draft-blog-post.mjs Outdated Show resolved Hide resolved

website/blog/2022-03-14-2.6.0.md Outdated Show resolved Hide resolved

website/blog/2022-03-14-2.6.0.md Outdated Show resolved Hide resolved

fisker approved these changes Mar 14, 2022

View reviewed changes

kachkaev approved these changes Mar 14, 2022

View reviewed changes

changelog_unreleased/blog-post-intro.md Outdated Show resolved Hide resolved

fisker reviewed Mar 15, 2022

View reviewed changes

fisker approved these changes Mar 15, 2022

View reviewed changes

kachkaev added this to the 2.6 milestone Mar 15, 2022

sosukesuzuki and others added 10 commits March 16, 2022 12:38

Generate

1b9a806

Generate

ee65572

Add TS4.6 changelog

97b95ec

Regenerate

4a886d0

Add changelog to switch to esbuild

07e21e7

Add category

bcd10d3

Update changelog_unreleased/blog-post-intro.md

ea04448

Co-authored-by: Jed Fox <git@jedfox.com>

Address review

0331b36

Regenerate

1142377

Highlight TS 4.6

6c88ca9

sosukesuzuki and others added 16 commits March 16, 2022 12:38

Update changelog_unreleased/blog-post-intro.md

efb1374

Co-authored-by: Jed Fox <git@jedfox.com>

Regenerate

f793f5c

Update changelog_unreleased/typescript/12390.md

6355231

Co-authored-by: Jed Fox <git@jedfox.com>

Add thanks message for sponsors

5f90a78

Address review!

f198e12

Update cspell.json

d954de7

Fix link of Ubie

e0ec775

Generate

310f4d1

Add Thanks to our sponsors!

fe9509d

Update cspell

ebe782c

Address review

c635273

Update changelog_unreleased/blog-post-intro.md

0b60288

Co-authored-by: Alexander Kachkaev <alexander@kachkaev.ru>

Regenerate

69ad31c

Add --print-truncate option

81f6965

Address review

b715e93

Generate

517000a

sosukesuzuki force-pushed the blog-post-2.6 branch from 17ba6d8 to 517000a Compare March 16, 2022 03:38

sosukesuzuki merged commit eb671dd into prettier:main Mar 16, 2022

sosukesuzuki deleted the blog-post-2.6 branch March 16, 2022 04:25

github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.6 blog post #12412

2.6 blog post #12412

sosukesuzuki commented Mar 7, 2022 •

edited

kachkaev commented Mar 8, 2022

j-f1 Mar 13, 2022

j-f1 Mar 13, 2022

fisker Mar 13, 2022

j-f1 Mar 13, 2022

sosukesuzuki commented Mar 13, 2022

fisker Mar 14, 2022 •

edited

sosukesuzuki Mar 14, 2022

fisker Mar 14, 2022

sosukesuzuki Mar 14, 2022

sosukesuzuki commented Mar 14, 2022

j-f1 left a comment

fisker left a comment

fisker Mar 15, 2022

sosukesuzuki Mar 15, 2022

kachkaev commented Mar 15, 2022

	And for TS that comment would not be stable with a second format:
	This change also fixes an issue where a similarly-placed comment in TypeScript would be moved again after a second formatting operation:

	{ dir: "others", title: "Others" },
	{ dir: "other", title: "Other" },

2.6 blog post #12412

2.6 blog post #12412

Conversation

sosukesuzuki commented Mar 7, 2022 • edited

Description

Checklist

kachkaev commented Mar 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sosukesuzuki commented Mar 13, 2022

fisker Mar 14, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sosukesuzuki commented Mar 14, 2022

j-f1 left a comment

Choose a reason for hiding this comment

fisker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kachkaev commented Mar 15, 2022

sosukesuzuki commented Mar 7, 2022 •

edited

fisker Mar 14, 2022 •

edited