-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.6 blog post #12412
2.6 blog post #12412
Conversation
I’ve just looked a blog post on TypeScript 4.6 — it does not seem to have any new syntax. How about mentioning this anyhow in the blog? We usually release a new minor version of Prettier after a new TypeScript release to support new syntax. If we don't say anything, some folks may think that we’ve forgotten about TS 4.6 and will go checking TS blog themselves. |
website/blog/2022-03-13-2.6.0.md
Outdated
}; | ||
``` | ||
|
||
And for TS that comment would not be stable with a second format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for TS that comment would not be stable with a second format: | |
This change also fixes an issue where a similarly-placed comment in TypeScript would be moved again after a second formatting operation: |
(still not 100% happy with this wording but I think it might be clearer)
scripts/draft-blog-post.mjs
Outdated
@@ -49,6 +49,7 @@ const categories = [ | |||
{ dir: "yaml", title: "YAML" }, | |||
{ dir: "api", title: "API" }, | |||
{ dir: "cli", title: "CLI" }, | |||
{ dir: "others", title: "Others" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ dir: "others", title: "Others" }, | |
{ dir: "other", title: "Other" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh misc
/“Miscellaneous” is good too!
@j-f1 Thanks for all the your reviews, every time! It is really helpful. |
@@ -8,6 +8,6 @@ This release includes a new `singleAttributePerLine` option. This is an option t | |||
|
|||
We've also added support formatting for some new JavaScript syntax proposals via Babel. | |||
|
|||
If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). | |||
If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to [LINE](https://line.me/en/) and [Ubie](https://ubie.life/en) for actually sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to [LINE](https://line.me/en/) and [Ubie](https://ubie.life/en) for actually sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/). | |
If you enjoy Prettier and would like to support our work, consider sponsoring us directly via [our OpenCollective](https://opencollective.com/prettier) or by sponsoring the projects we depend on, including [typescript-eslint](https://opencollective.com/typescript-eslint), [remark](https://opencollective.com/unified), and [Babel](https://opencollective.com/babel). Also thanks to some amazing sponsors such as [LINE Corporation](https://opencollective.com/line), [Airbnb](https://opencollective.com/airbnb), [Nx (by Nrwl)](https://opencollective.com/nx), [Ubie](https://opencollective.com/ubie-inc), and many others for sponsoring us! For more information on LINE's OSS sponsoring, please read the blog post [LINE has started to donate to Prettier – why companies should support OSS](https://engineering.linecorp.com/en/blog/support-prettier-and-oss/). |
Let's link to their opencollective account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should link to their OpenCollective. This is because the company that sponsored us would want us to see the company's website rather than the OpenCollective link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have their production links on OpenCollective account.
Anyway, can you add "Airbnb" and "Nx"? They are doing generous donation monthly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, can you add "Airbnb" and "Nx"? They are doing generous donation monthly.
Sure!
Btw, as you mentioned in Discord, I think we should add sponsors in our website.
@j-f1 Could you review |
1739493
to
1ea4630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few small tweaks, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
scripts/draft-blog-post.mjs
Outdated
@@ -74,7 +84,7 @@ fs.writeFileSync( | |||
replaceVersions( | |||
[ | |||
fs.readFileSync(introFile, "utf8").trim(), | |||
"<!--truncate-->", | |||
shouldPrintTruncate ? "<!--truncate-->" : "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not check if blog-post-intro.md contains <!--truncate-->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 17ba6d8
Let’s rename the file: -website/blog/2022-03-15-2.6.0.md
+website/blog/2022-03-16-2.6.0.md Based on: #12410 (comment) |
Co-authored-by: Jed Fox <git@jedfox.com>
Co-authored-by: Jed Fox <git@jedfox.com>
Co-authored-by: Jed Fox <git@jedfox.com>
Co-authored-by: Alexander Kachkaev <alexander@kachkaev.ru>
17ba6d8
to
517000a
Compare
Description
https://deploy-preview-12412--prettier.netlify.app/blog/2022/03/15/2.6.0.html
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨